From dbff1de0fec200fd27c6710ee8e607120fc88e16 Mon Sep 17 00:00:00 2001 From: brad-gh <32170926+brad-gh@users.noreply.github.com> Date: Tue, 26 Apr 2022 23:12:49 -0400 Subject: [PATCH] fix: formulation --- piscine/week01/day05/ex04/audit/README.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/piscine/week01/day05/ex04/audit/README.md b/piscine/week01/day05/ex04/audit/README.md index 89e9d8d..aa4c452 100644 --- a/piscine/week01/day05/ex04/audit/README.md +++ b/piscine/week01/day05/ex04/audit/README.md @@ -1,9 +1,9 @@ ##### The exercice is validated is all questions of the exercice are validated -###### Have you checked missing values and data types ? -###### Have you converted string dates to datetime ? -###### Have you set dates as index ? -###### Have you used `info` or `describe` to have a first look at the data ? +###### Have the missing values and data types been checked ? +###### Have the string dates been converted to datetime type ? +###### Have the dates been set as index ? +###### Have `info` or/and `describe` been used to have a first look at the data ? @@ -57,6 +57,6 @@ Name: PnL, Length: 10119, dtype: float64 ``` -##### The question 4 is validated if you computed the return of the strategy as: `(Total earned - Total invested) / Total` invested. The result should be close to 0. The formula given could be simplified as `(PnLs.sum())/signal.sum()`. My return is: 0.00043546984088551553 because I invested 5147$ and I earned 5149$. +##### The question 4 is validated if the return of the strategy is computed as: `(Total earned - Total invested) / Total` invested. The result should be close to 0. The formula given could be simplified as `(PnLs.sum())/signal.sum()`. My return is: 0.00043546984088551553 because I invested 5147$ and I earned 5149$. -##### The question is validated if you replaced the previous signal Series with 1s. Similarly as the previous question, we earned 10128$ and we invested 10118$ which leads to a return of 0.00112670194140969 (0.1%). \ No newline at end of file +##### The question is validated if the previous signal Series is replaced with 1s. Similarly as the previous question, we earned 10128$ and we invested 10118$ which leads to a return of 0.00112670194140969 (0.1%).